Simplify page list edit warning #56829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Copy
getdave
requested review from
draganescu,
scruffian,
richtabor,
alexstine and
annezazu
|
Size Change: +1.11 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ec33146. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7134867293
|
richtabor
reviewed
Dec 6, 2023
|
|
||
| export const convertDescription = createInterpolateElement( | ||
| __( | ||
| "The page list displays your site's published pages. If you choose to independently edit, your navigation will no longer <em>automatically</em> update when your pages change." |
There was a problem hiding this comment.
What about something like this:
The page list block displays your website's pages. Editing the block will allow you to add, delete, or reorder pages, although new pages will no longer be added automatically to this navigation.
There was a problem hiding this comment.
+1 to Rich's suggestion with a slight alternative to consider:
The page list block displays all of your published pages as a menu, including any new pages. Editing this block allows you to add, delete, and reorder items but will prevent any new pages from being added going forward.
There was a problem hiding this comment.
Thanks for your input 👍 I appreciate the alternative ideas.
I like Rich's idea, but I think we should consider making the wording about what will happen rather than describing the page list block.
Here's my slightly tweaked alternative which:
- describes the current state of your menu.
- explains what proceeding with the proposed change will enable
- explains the consequences of proceeding with the change
This menu is currently displaying your website's pages. Editing it will allow you to add, delete, or reorder pages, but new pages will no longer be automatically added to this navigation.
I think the key concept to get across to folks is that it will not automatically update with changes to your pages. The word "automatic" is much more approachable than "sync" and everyone knows what it means.
...but will prevent any new pages from being added going forward.
Nit: Is this true? You can easily add pages using the navigation link blocks. I'd prefer to avoid the word "prevent" as well.
There was a problem hiding this comment.
Updated to my suggestion here.
Still open for alternatives or we can merge and iterate... 🤷
alexstine
approved these changes
Dec 7, 2023
|
|
||
| export const convertDescription = createInterpolateElement( | ||
| __( | ||
| "This menu is currently displaying your website's pages. Editing it will allow you to add, delete, or reorder pages, but new pages will no longer be <em>automatically</em> added to this navigation." |
There was a problem hiding this comment.
Suggested change
| "This menu is currently displaying your website's pages. Editing it will allow you to add, delete, or reorder pages, but new pages will no longer be <em>automatically</em> added to this navigation." | |
| "This menu is currently displaying your website's pages. Editing it will allow you to add, delete, or reorder pages, but new pages will no longer be <em>automatically</em> added to this menu." |
There was a problem hiding this comment.
Perhaps both, "navigation menu".
There was a problem hiding this comment.
Thanks Alex.
Rich - I think it has to be because we deliberately tried to disambiguate "menu" (navigation menu) and "menu" (restaurant menu).
Don't see any harm in using both terms for extra clarity 👍
There was a problem hiding this comment.
I just realised we also use "menu" in the first paragraph. We could use navigation menu both times. Technically that is what it is...
There was a problem hiding this comment.
I updated in 19e7a72.
I will merge sometime tomorrow unless there are any further objections.
Thank you everyone.
getdave
commented
Dec 7, 2023
|
Made a small tweak for readability + removed the emphasis. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Simplifies the wording of the modal that appears once you "Edit" a Page List block inside a Navigation block.
I'm totally open to alternative suggestions, but we need something that is succinct and avoids technically complex words.
Closes #54625
Why?
Currently the wording is very technical and can be hard to appreciate what will happen when you click affirmative.
How?
Uses more user-facing terminology that is more specific to Navigation Menus.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast