Sort order: Use unicode characters instead of svg icons #56833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +105 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1bb3ccc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7224249531
|
jasmussen
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
From an experience point of view this makes the behavior feel integrated with the column head, and is worth a shot.
I'd love a sanity check from @andrewhayward that it's announced correctly. From my experience, it is.
Visually this change is fine, but see my comment about hiding the arrow. |
Co-authored-by: Andrew Hayward <andrew.hayward@automattic.com>
bph
added
[Type] Experimental
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Co-authored-by: Andrew Hayward <andrew.hayward@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In data views table layout; use unicode characters instead of svg icons to communicate sort order.
Why?
Feels more integrated and lighter weight.
Testing Instructions