-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary isDisabled option on useShortcut for BlockToolbarPopover #56907
Conversation
Size Change: -4 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in 0a28e6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7143181794
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢 it
What?
Removes the
isDisabled
option onuseShortcut
within<BlockToolbarPopover />
Why?
useShortcut
already uses a default ofisDisabled
, so this code is redundant.How?
Deletes the
isDisabled
object option.Testing Instructions
alt+F10
shortcut should work on the block toolbar popover.