Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Icons: update Patreon icon #56951

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Social Icons: update Patreon icon #56951

merged 5 commits into from
Jan 30, 2024

Conversation

jeherve
Copy link
Contributor

@jeherve jeherve commented Dec 11, 2023

Fixes #56925

What?

Let's update the Patreon logo.

Why?

Patreon's logo is changing: https://news.patreon.com/articles/patreon-reimagined
Our Social Icons logo should change too.

How?

This uses the new logo provided in the branding guidelines here:
https://www.patreon.com/brand

Testing Instructions

  1. Go to Posts > Add New
  2. Add a new Social Icons block
  3. Add a new Patreon block.

Testing Instructions for Keyboard

Similar as above

Screenshots or screencast

On the frontend

Screenshot 2023-12-11 at 15 45 00

In the editor

Screenshot 2023-12-11 at 15 44 36 Screenshot 2023-12-11 at 15 44 32

@jeherve
Social Icons: update Patreon icon
15dd5b3 
Fixes WordPress#56925

Patreon's logo is changing: https://news.patreon.com/articles/patreon-reimagined
Our Social Icons logo should change too.
@jeherve jeherve mentioned this pull request Dec 11, 2023
Closed
@skorasaurus skorasaurus added the [Block] Social Affects the Social Block - used to display Social Media accounts label Dec 14, 2023
@t-hamano t-hamano added the [Type] Enhancement A suggestion for improvement. label Jan 26, 2024
@t-hamano
Copy link
Contributor

Sorry for the delay in confirming this PR. In order to move this PR forward, could you do the following?

  • Just to be safe, rebase on the latest trunk branch
  • I noticed that this icon variation does not have a fixture file. We might want to generate a fixture file for this variation, like when you added the Gravatar icon in Social Icons: add Gravatar service #56544.
  • Is it possible to center the icons perfectly? I checked the SVG updated by this PR and it looks like it's positioned a little above.

When checking SVG data in Illustrator:

image

@jeherve
Copy link
Contributor Author

jeherve commented Jan 29, 2024

👍 I've just done all that. Thanks for the feedback.

@t-hamano t-hamano self-requested a review January 29, 2024 11:34
t-hamano
t-hamano approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The icon is perfectly centered and the fixture files look fine too.

I would like to merge this PR, but unfortunately it seems that one GitHub Action (React Native E2E Tests) always fails on the latest trunk. So you will probably need to merge the latest trunk into this PR one last time after that issue is resolved.

We will notify you as soon as the issue is resolved.

@t-hamano
Copy link
Contributor

It seems that the issue with GitHub actions in trunk has been resolved. Could you merge the latest trunk one more time? I would like to merge this PR as soon as all GitHub Actions pass 🙇

@jeherve
Copy link
Contributor Author

jeherve commented Jan 30, 2024

👍 Done

@t-hamano t-hamano merged commit 2b608f9 into WordPress:trunk Jan 30, 2024
54 checks passed
@t-hamano
Copy link
Contributor

Thank you, merged 🚀

@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 30, 2024
@jeherve jeherve deleted the update/patreon-icon branch January 30, 2024 14:09
@evalarumbe
Copy link

Hooray, thanks all :D Where should I watch to see which version this is released in?

@t-hamano
Copy link
Contributor

Where should I watch to see which version this is released in?

This PR will be shipped as part of Gutenberg plugin version 17.7. This version will also be included in the upcoming WordPress 6.5.

@hanneslsm hanneslsm mentioned this pull request Feb 15, 2024
Closed
@AnukratiMehta AnukratiMehta mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 17.7
Development

Successfully merging this pull request may close these issues.

Social Links Block: update Patreon Logo
4 participants
@jeherve @t-hamano @evalarumbe @skorasaurus