Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add storybook link for spinner component #56953

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

apeatling
Copy link
Contributor

What?

Follow up to #56818 that was reverted. This places the added storybook link in the spinner component doc.

Why?

The previous PR placed it in the search component docs by mistake.

How?

Adding the link.

Testing Instructions

Check the link to storybook works.

@apeatling apeatling requested a review from bph December 11, 2023 18:25
@apeatling apeatling self-assigned this Dec 11, 2023
Copy link

Flaky tests detected in 1a171d8.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7171734615
📝 Reported issues:

@apeatling apeatling added the [Type] Developer Documentation Documentation for developers label Dec 11, 2023
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice attention to detail! This updates the Spinner docs page with the correct link to Storybook, which I see is referenced from the https://learn.wordpress.org/lesson/retrieving-wordpress-data-records/ tutorial page. That page also has a link to the SearchControl page which appears to already include the link to the appropriate Storybook entry, so looks like this PR finishes things off 👍

LGTM! ✨

@andrewserong
Copy link
Contributor

Oh, I see the @wordpress/components changelog entry job is complaining. It might be worth adding an entry to the CHANGELOG.md file to get that passing before merging?

@apeatling apeatling merged commit 9080cb6 into trunk Dec 11, 2023
53 of 56 checks passed
@apeatling apeatling deleted the add/spinner-storybook-doc branch December 11, 2023 22:59
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 11, 2023
@apeatling
Copy link
Contributor Author

@andrewserong I will follow up on that now. I merged at the same time you posted that comment!

@andrewserong
Copy link
Contributor

Apologies! I only saw the red cross against that Github action after I hit submit 😄

@apeatling
Copy link
Contributor Author

apeatling commented Dec 11, 2023

Changelog updating PR here #56960

@bph
Copy link
Contributor

bph commented Dec 13, 2023

Thank you @apeatling for taking my idea over the finish line by fixing my mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants