Editor: Fix display of edit template blocks notification #56978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 461b5b1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7189112781
|
|
I noticed this was also occurring in the site editor when editing a page with template preview turned off. 2023-12-13.11.34.32.mp4This PR also fixes that 🎉 |
ramonjd
approved these changes
Dec 13, 2023
andrewserong
force-pushed
the
fix/edit-template-blocks-notification-display
branch
from
c0e4b66
to
461b5b1
Compare
andrewserong
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
This is testing nicely for me, too, thanks for fixing it up!
✅ In the post editor, the notice is only displayed when the template preview mode is on
✅ In the site editor, it shows by default when editing a page, as it defaults to the template preview (template-locked) mode
I noticed a couple of the e2e tests were failing consistently. I'm 99% sure it's the failures fixed up by #56992, but just to be sure, I've given this a rebase.
LGTM! ✨
|
This PR will close #56979. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #56979
I noticed that when we drag the cursor to have a multi selection in post editor the notification to edit the template is shown. This is because in post editor when we perform the above action, the event target is the post content block which contains the
is-root-containercss class.I believe this notification makes sense only in
template-lockedmode and this PR updates the check to do that.Screen.Recording.2023-12-12.at.2.23.24.PM.mov
Testing Instructions