Comments block: Try client-side form submission [new store API] #56984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +738 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 35aa650. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7184430341
|
|
Currently failing on the frontend (if a Comments block is present): 
|
|
👋 @luisherranz Any advice on the above error? 😬 |
|
Thank you @DAreRodz for getting this to work! |
20 tasks
luisherranz
changed the base branch from
trunk
to
try/client-side-form-submission-of-comments-form-block
luisherranz
changed the base branch from
try/client-side-form-submission-of-comments-form-block
to
trunk
luisherranz
reviewed
Dec 14, 2023
| }, | ||
| }, | ||
| actions: { | ||
| submit: async ( event ) => { |
There was a problem hiding this comment.
This needs to use * instead of async and yield instead of await 🙂
|
I've carried the changes back over to #53737. Closing this PR. |
ockham
deleted the
try/client-side-form-submission-of-comments-form-block-take-two
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Attempt updating #53737 to use the new Store API.
Why?
As a preparatory step to working on fetching required block styles and scripts upon comment submission.
How?
By looking at this diff and this.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast