Query: Try adding infinite scroll loading #56987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Technical Prototype
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: +610 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2a39741. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7195816355
|
|
Hey @gziolo, Really need to watch accessibility with an approach like this. Any type of load more action needs to very carefully manage focus and communicate clearly to assistive technology. I would much prefer we keep the pagination approach. Please get reviews from the Accessibility Team if you get this in a place ready for reviews. Thanks. |
|
Hey @alexstine, absolutely 🙂 This was just a quick proof of concept to test how the |
|
@alexstine, it feels so great having your comment on the early prototype for one of the potential features we could add to the Query block or Comments block. I wanted to echo what Luis said. There is no immediate plan to continue working on it, but once we get back to it, we definitely will reach out to the Accessibility team for support in shaping how it all works. Many classic themes use the infinite scroll feature, so it would be great to add it for feature parity, but we have this unique opportunity to make it accessible for everyone by leveraging the Interactivity API.
The way the Query block works without the page reload covers the communication part when using assistive technology. It announces that the page has changed using the same mechanism as in the block editor. We definitely could reuse that for infinite scroll. Do you have some initial thoughts on how we could go about the focus management? This is what I was thinking so far. If we put the |
gziolo
added
[Feature] Interactivity API
|
@gziolo I think placing focus on the newly loaded post is okay. |
|
I opened #59943 to track it. I'm closing the prototype for now as I don't plan to work on it in the upcoming weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #59943.
Many classic themes use the infinite scroll feature, so it would be great to add it for feature parity to core blocks. We have this unique opportunity to make it accessible for everyone by leveraging the Interactivity API. This PR explores what is necessary to add the feature to the Query Loop block.
This is an early prototype. There is no immediate plan to land it in the Gutenberg plugin. However, it would be great to gather some initial feedback about the requirements for making it accessible.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Infinite.scroll.mp4