Components: replace TabPanel with Tabs in the Block Inspector
#56995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
|
Size Change: +569 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 13d3bc8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7224572633
|
chad1008
force-pushed
the
tabs-block-inspector
branch
from
1480440
to
b5fcc8b
Compare
chad1008
changed the title
Tabs in block-inspectorTabPanel with Tabs in the Block Inspector
chad1008
force-pushed
the
tabs-block-inspector
branch
from
b5fcc8b
to
13d3bc8
Compare
ciampo
approved these changes
Dec 19, 2023
packages/block-editor/src/components/inspector-controls-tabs/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/inspector-controls-tabs/index.js
Outdated
Show resolved
Hide resolved
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
…6995) * implement `Tabs` * focusable false * add `show-icon-labels` support * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces the legacy TabPanel component with the new Tabs component.
Why?
Part of the work outlined in #52997
How?
TabPanelis replaced byTabsand its sub-components.Testing Instructions
show-icon-labelsclass to the page'sbodytag. Confirm that the tab icons are replaced with the appropriate labels.Testing Instructions for Keyboard
tabpanelitself