Interactivity API: fix namespaces in nested interactive regions #57029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Bug
DAreRodz
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad,
ajitbohra and
luisherranz
as code owners
|
Size Change: +10 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dab4e13. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7220386069
|
cbravobernal
approved these changes
Dec 15, 2023
DAreRodz
force-pushed
the
fix/interactivity-api-nested-namespaces
branch
from
d45725d to
dab4e13
Compare
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Add failing test * Turn namespaces into a stack inside `toVdom` * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a problem with namespaces not being restored when a nested interactive region changes it. E.g.:
Why?
The case described above makes
state.messagenot to be resolved correctly because it tries to readmessagefrom namespace B. It likely returns an error like the following:We need to ensure the property is read from the right namespace.
How?
A single variable to store the current namespace was used before. I replaced that with a namespace array that works as a stack.
Testing Instructions
To reproduce the issue:
trunk. In the editor, go to the home blog template.To verify the fix: