DataViews: centralize control of filter visibility in the Filters component
#57056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Experimental
|
Size Change: -5 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1bc6050. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7207661920
|
|
Nice, but I think we can further improve this. To me, it doesn't make much sense that if ( condensed ) {
return <AddFilter … />
}
const visibleFilters = filters.filter( ( { isVisible } ) => isVisible );
return (
<>
<AddFilter … />
{ visibleFilters.map( ( filters ) => <FilterSummary … /> }
{ visibleFilters.length > 0 && <ResetFilters … /> }
</>
);My only remaining question is whether the caller, like PagePages, should be the one setting the prop upon calling |
I thought about this and decided against. I can share my thinking, and happy to follow-up. Options I considered:
Of course, this is only about where the logic should live. Readability can always be improved, and I'm happy to act on that if I'm pointed to specifics. |
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
See #56983 (comment)
What?
This is a code quality change: it centralizes the visibility conditions of the filters subcomponents (add filter, reset filter) in the
<Filters>component.Testing Instructions