-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data views: Add hover style to table rows #57058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
A suggestion for improvement.
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
labels
Dec 14, 2023
Size Change: +24 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in 54317c5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7207978373
|
ntsekouras
approved these changes
Dec 14, 2023
bph
added
[Type] Experimental
Experimental feature or API.
and removed
[Type] Enhancement
A suggestion for improvement.
labels
Dec 24, 2023
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a hover style to rows in Table layout.
Why?
Highlighting the hovered row makes it much easier to ensure you're working with the correct item. This is particularly useful on wide screens where the right-most column can be a great distance from the identifier (title).
How
Apply hover style to
.dataviews-table-view tr td:hover
. The background color matches the one used in List layout. Ideally this is made into a variable in the future.To test
Screenshot