Added additional explanations to attributes and supports sections #57120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove unneeded pages
juanmaguitar
requested review from
ajitbohra,
ryanwelcher,
fabiankaegy and
ndiego
as code owners
juanmaguitar
added
the
[Type] Developer Documentation
|
Flaky tests detected in dad8647. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7226548664
|
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Co-authored-by: Nick Diego <nick.diego@automattic.com>
…rt of the paragraph
|
Thanks for your suggestions @ndiego |
ndiego
deleted the
docs/fundamentals-block-development---block-json-incorporate-content
branch
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
…7120) * Added additional explanations to attributes and supports sections and remove unneeded pages * Update docs/getting-started/fundamentals/block-json.md Co-authored-by: Nick Diego <nick.diego@automattic.com> * Update docs/getting-started/fundamentals/block-json.md Co-authored-by: Nick Diego <nick.diego@automattic.com> * Update docs/getting-started/fundamentals/block-json.md Co-authored-by: Nick Diego <nick.diego@automattic.com> * Update docs/getting-started/fundamentals/block-json.md Co-authored-by: Nick Diego <nick.diego@automattic.com> * Update docs/getting-started/fundamentals/block-json.md Co-authored-by: Nick Diego <nick.diego@automattic.com> * Update docs/getting-started/fundamentals/block-json.md Co-authored-by: Nick Diego <nick.diego@automattic.com> * Update docs/getting-started/fundamentals/block-json.md Co-authored-by: Nick Diego <nick.diego@automattic.com> * Update docs/getting-started/fundamentals/block-json.md Co-authored-by: Nick Diego <nick.diego@automattic.com> * Update sentence about attributes description * Fine-tune sentence about attributes * restore these parenthesis as this sentence refers only to the last part of the paragraph --------- Co-authored-by: Nick Diego <nick.diego@automattic.com>
|
Rather than removing pages and breaking links, wouldn't it be better to just remove the links and archive these pages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some additional context for the Data Storage in the Block with attributes and Enable UI settings panels for the block with supports sections and removes related pages under How to guides > blocks as I consider the content in them is properly covered with the pages under "Fundamentals of Block Development"
The pages removed are:
attributesare already introduced in Data Storage in the Block with attributes and an example of an editable text component is already covered in the coming-soon tutorial@ndiego for the following pages a redirection to block.json would be needed: