InnerBlocks: overlay: remove viewport size condition #57135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5d05410. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7234336076
|
youknowriad
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I don't understand why we are enabling "click through"/overlay for small screen, but not desktop.
Either we should remove this overlay for small screens too, or add it for all sizes.
I believe this is causing an issue on small screens where you can't immediately focus a list item.
Additionally it has a small but noticeably performance impact because every single block list is checking the viewport size, which is not a cheap operation.
Related:
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast