Platform Docs: Fix missing link #57145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
platform-doc/missing-link
branch
from
ff17532
to
7d373e3
Compare
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7740e98. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7246246973
|
youknowriad
reviewed
Dec 18, 2023
| @@ -100,7 +100,7 @@ After running this through the parser, we're left with a simple object we can ma | |||
|
|
|||
| This has dramatic implications for how simple and performant we can make our parser. These explicit boundaries also protect damage to a single block from bleeding into other blocks or tarnishing the entire document. It also allows the system to identify unrecognized blocks before rendering them. | |||
|
|
|||
| _N.B.:_ The defining aspects of blocks are their semantics and the isolation mechanism they provide: in other words, their identity. On the other hand, where their data is stored is a more liberal aspect. Blocks support more than just static local data (via JSON literals inside the HTML comment or within the block's HTML), and more mechanisms (_e.g._, global blocks or otherwise resorting to storage in complementary `WP_Post` objects) are expected. See [attributes](/docs/reference-guides/block-api/block-attributes.md) for details. | |||
| _N.B.:_ The defining aspects of blocks are their semantics and the isolation mechanism they provide: in other words, their identity. On the other hand, where their data is stored is a more liberal aspect. Blocks support more than just static local data (via JSON literals inside the HTML comment or within the block's HTML), and more mechanisms (_e.g._, global blocks or otherwise resorting to storage in complementary `WP_Post` objects) are expected. See [attributes](https://github.com/WordPress/gutenberg/tree/HEAD/docs/reference-guides/block-api/block-attributes.md) for details. | |||
There was a problem hiding this comment.
I think maybe we should remove the link for now, until we have a dedicated reference for attributes (to avoid confusing them with WP jargon)
There was a problem hiding this comment.
I see. I deleted the entire sentence including the link, is this correct?
youknowriad
approved these changes
Dec 18, 2023
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Platform Docs: Fix missing link * Remove link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #53874
What?
This PR fixes one link. This will also allow the
npm run buildcommand to work correctly.Why?
The
/docs/path link will work correctly in markdown on GitHub repository. However, if this document is published in the future, the docs directory will not exist and will not be linked correctly.Testing Instructions
./platform-docsnpm installnpm run build