Swap Template: Show the right templates for the right post type #57149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
Size Change: +22 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5fb36c9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7248083451
|
t-hamano
reviewed
Dec 18, 2023
There was a problem hiding this comment.
LGTM!
- In the editor where the post type is
post, I only see the "post" specific templates in the swap template modal. - In the editor where the post type is
page, I only see the "page" specific templates in the swap template modal. - It works the same way when I create a custom post type and define it in
customTemplatesin theme.json. - If I select any page in the Site Editor, I only see the "page" specific templates in the swap template modal.
| return useSelect( | ||
| ( select ) => | ||
| select( coreStore ).getEntityRecords( 'postType', 'wp_template', { | ||
| per_page: -1, | ||
| post_type: 'page', | ||
| post_type: postType, | ||
| } ), | ||
| [] |
There was a problem hiding this comment.
Does it make sense to add postType to avoid an eslint warning error regarding a dependency?
ntsekouras
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
LGTM, thanks! We should add the postType in deps though as @t-hamano suggests.
bph
added
the
[Feature] Site Editor
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #57112
What?
We recently moved the template swapping modal to the post editor, this highlighted a small issue where the list of available templates was hardcoding the templates that are available for the page post type. This PR fixes that by using the right post type to fetch the available templates.
Testing Instructions
1- Edit a post in 2024 theme, you should only see the "post" specific templates in the swap template modal.
2- For pages, you should only see "page" specific templates.