Editor: Move and unify the inserter and list view states #57158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +188 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bbbe2ff. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7248226197
|
draganescu
approved these changes
Dec 18, 2023
|
Nice one! Good to move toward combining these, it's often a bit of a pain dealing with duplication surrounding the list view, and starting with combining the state is a good approach 👍 |
bph
added
[Feature] List View
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR continues the work on the great unification between post and site editors. This is a preparation PR. In order to unify the inserters and the list views and the headers of the editors, we need to ensure they're using the same state. So this PR moves the list view and inserter states (selectors and actions) to the editor package. There should be no functional change, e2e tests should help us validate the change.