Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font size picker: use Button API for keeping focus on reset #57221

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Font size picker: use Button API for keeping focus on reset #57221

merged 1 commit into from
Dec 19, 2023

Conversation

ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Dec 19, 2023 •
edited
Loading

What?

Follow up of: #57196 (comment)

For the time being, it's probably better to use the current set of props that Button makes available:

@ntsekouras ntsekouras added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 19, 2023
@ntsekouras ntsekouras self-assigned this Dec 19, 2023
@ntsekouras ntsekouras requested a review from ciampo December 19, 2023 13:45
ciampo
ciampo approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ntsekouras ntsekouras enabled auto-merge (squash) December 19, 2023 14:07
@ntsekouras ntsekouras merged commit a76800c into trunk Dec 19, 2023
56 checks passed
@ntsekouras ntsekouras deleted the use/button-api-to-keep-focus-on-reset branch December 19, 2023 14:11
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 19, 2023
artemiomorales pushed a commit that referenced this pull request Jan 4, 2024
@ntsekouras @artemiomorales
Font size picker: use Button API for keeping focus on reset (#57221)
5c9fb9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ntsekouras ntsekouras

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ntsekouras @ciampo