-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate 'Comments Form' e2e tests to Playwright #57337
Conversation
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
Flaky tests detected in db1c015. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7300122809
|
* @return {Promise<string>} A Promise that resolves to the option's | ||
* previous value. | ||
*/ | ||
async setOption( setting, value ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker but could we still call fetch API to set this via requestUtils
like in #56663? (Also would love your review on that one 😆)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was confused by the comment "REST API is not exposed" written in the original test, but this option was available via getSiteSettings
and setSiteSettings
🤣 Since there is no need for a unique util class, I was able to write it very simply.
What?
Part of #38851.
PR migrates
post-comments-form.test.js
e2e tests to Playwright.How?
experiments
directory in #40368. But my understanding is that this block is not supposed to be experimental, so I moved it to theeditor/blocks
directory.beforeEach
/AfterEach
instead ofbeforeAll
/AfterAll
. (See more context here).Testing Instructions