Components: Improve Disabled component (disabled attribute applicable, tabindex removal, pointer-events) #5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] UI Components
|
@aduth I can't find the changes where the blocks.BlockEdit were disabled on blocks inside the columns. I thought it's this one, would you mind pointing me to the right direction? I've created this plugin : http://wordpress.org/plugins/block-options/ and the options I've added are not showing on the inner columns anymore. Thanks! |
|
Addressed at #6312 in response to duplicate comment at #6237 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5658 (comment)
This pull request seeks to improve the
Disabledcomponent to improve its durability in accurately disabling all interaction for content within. It resolves erroneous application ofdisabledattribute to non-eligible nodes as defined by the specification, removes anytabindexattribute as these elements are intended to be omitted from the tabbable flow, and prevents pointer interactions (the specification is not entirely clear here except for mention of preventing click events, and while the issue is under discussion at whatwg/html#2368 and w3c/pointerevents#177, the behavior is consistent with the majority of browsers).Testing instructions:
The behavior on master is unlikely to change.
This was observed in the course of reviewing #5658, where mouse events on disabled controls being fired conflicts with hover behavior of accessing block options of a shared block preview of a nested block. Testing may require cherry-picking commits into
try/improve-nesteduntil the pull request is merged.