Footnotes: fix wrong link when adding more than 9 footnotes #57599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +35 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
@mcsf Thanks for the review! |
github-actions
bot
added
the
[Status] In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57321
Related to #54505
What?
This PR fixes an issue where the link text is not applied correctly when the footnote number is 10 or higher.
Why?
My understanding is that the newly added footnote will have the asterisk as their text.
Then,
RichTextValueobject is generated using the code below.gutenberg/packages/core-data/src/footnotes/index.js
Lines 74 to 76 in 3ddd037
Since the asterisk is a single character, the
RichTextValueobject will look like this:The current implementation replaces the asterisk with the actual text after generating the
RichTextValueobject, resulting in a mismatch between the length of thetextand the length offormats/replacements:How?
I made sure to duplicate the
formatsandreplacementselements by the length of the actual string.Another approach is to replace the asterisk with the actual value when creating the
RichTextValueobject.This approach is very simple, but I feel it's a bit unstable since it relies on HTML strings.
Testing Instructions
When adding 10 or more footnotes, check that the numbers are linked correctly.
Note
There seems to be a bug that immediately after adding a footnote, it remains an asterisk unless the block is selected. This issue was reported in #57598.