Patterns: Add black border back when editing synced pattern in the post editor #57631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +2.02 kB (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
49 tasks
ramonjd
reviewed
Jan 10, 2024
| @@ -1,5 +1,6 @@ | |||
| .editor-canvas__iframe { | |||
| &.has-history { | |||
| padding: $grid-unit-60 $grid-unit-60 0; | |||
| background-color: $gray-900; | |||
There was a problem hiding this comment.
This color already exists for .edit-post-visual-editor:
Could we somehow leverage that?
Or switch off the #fff background color for iframe[name=editor-canvas] using the has-history class. Here: https://github.com/WordPress/gutenberg/blob/1b2dac78b60c4bab6d1dcb771498d99fbea2ff54/packages/block-editor/src/components/block-canvas/style.scss
That way we don't need this new CSS file.
There was a problem hiding this comment.
Here's this PR using a theme (empty theme) that doesn't specify a background color:
2024-01-11.10.16.49.mp4
Maybe not as important as the issue raised in #57330 so long as the pattern is visible?
There was a problem hiding this comment.
I think it achieves what we want. I can't see any regressions from #57330 👍🏻
…dditional css file
ramonjd
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the black border back when editing a synced pattern in isolation in the post editor.
Why?
The black background was originally just showing due to a bug which was fixed in #57330. Since this fixed the border is displaying as white.
How?
Explicitly set the black border when the pattern is in the focused edit mode, which is identified if the
.has-historyclass is set.Testing Instructions
Edit originalin the toolbarScreenshots
Before:
pattern-border-before.mp4
After:
pattern-edit-border.mp4