Data views: Update pagination spacing in List layout #57670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Feature] DataViews
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
jameskoster
added
[Type] Experimental
|
Size Change: +55 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
For what it's worth, I still think there are some opportunities for a different design that has the page selection element much less prominent. IMO it can be as simple as |
|
@jasmussen those patterns would cause the next/previous buttons to jump around as you navigate due to the variable width of the numbers.
That's essentially what we have. SelectControl is used as it offers a better experience for keyboard navigation (you can effectively type to search which is handy for longer lists). However SelectControl doesn't have many display options. It would be nice to have a way to remove the border, but that becomes separate discussion. Let's open an issue. |
We could still improve the visuals there, omitting the "Page", and styling the select control to have a much lighter footprint. Right now it awkwardly spaces the number in the dropdown. |
|
Oh I totally agree that we should aim for a lighter footprint. But rather than adding component overrides I'd prefer to build that into SelectControl so that it can be reused in other locations like the operator UI: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up to #57644, where pagination spacing was updated to bring the page selector closer to the next/previous buttons. This works well in 'full-width' layouts like Grid / Table, but in the List layout it looks a little clumsy due to the narrower width.
In this PR the page selector is aligned left in List layout which is more balanced while still being close to the next/previous buttons.