Template part block: avoid parsing ALL patterns on mount #57856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +57 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
ellatrix
force-pushed
the
try/avoid-patters-parsing-on-load
branch
from
97e9d37
to
f6ddae1
Compare
youknowriad
approved these changes
Jan 18, 2024
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently the site editor seems to trigger parsing all the patterns on load. This is happening because the template part blocks is selecting
getPatternsByBlockTypesin the edit function.Observations:
getPatternsByBlockTypesis parsing ALL the patterns. Ideally one first gets the subset, then parse the patterns.The solution I went for here is to avoid calling the expensive selector until that menu item is rendered, since this also reduces the number of subscriptions.
Why?
This is on load
This is the template library (grid). All the red stuff is gone now.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast