Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: Update uninstall/delete on client side #57932

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Font Library: Update uninstall/delete on client side #57932

merged 10 commits into from
Jan 18, 2024

Commits on Jan 17, 2024

  1. Fix delete endpoint

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9f7bde1 View commit details
    Browse the repository at this point in the history

  2. Update fetchUninstallFontFamily to match new format

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1c9aa8d View commit details
    Browse the repository at this point in the history

  3. Update uninstallFont

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9b90a18 View commit details
    Browse the repository at this point in the history

  4. Add uninstall notice back in

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bcbbd81 View commit details
    Browse the repository at this point in the history

  5. Tidy up comments

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c96bf23 View commit details
    Browse the repository at this point in the history

  6. Re-word uninstall notices

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    454eb26 View commit details
    Browse the repository at this point in the history

  7. Add spacing to error message

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    371a221 View commit details
    Browse the repository at this point in the history

  8. Refactored how font family values were processed so they would retain… 

    … their id, which is now used to delete a font family without fetching data via slug
    @pbking
    pbking committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    530939f View commit details
    Browse the repository at this point in the history

  9. Rename uninstallFont to uninstallFontFamily

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    46124cb View commit details
    Browse the repository at this point in the history

  10. Throw uninstall errors rather than returning them

    @mikachan
    mikachan committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bed9b8a View commit details
    Browse the repository at this point in the history