Add shadow support for column, columns and image #57982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
|
Size Change: +104 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
vcanales
force-pushed
the
add-shadow-supports
branch
from
50da155 to
6fa2a0f
Compare
2 tasks
|
Would it be possible to add box shadow support to the Column block as well? I believe this would be a valuable addition to enhance individual column styling. |
vcanales
force-pushed
the
add-shadow-supports
branch
from
6fa2a0f to
936f2f9
Compare
vcanales
requested review from
artemiomorales,
michalczaplinski and
ajitbohra
as code owners
vcanales
requested review from
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
vcanales
requested review from
spacedmonkey,
kevin940726,
Mamaduka,
ntwb,
nerrad and
ellatrix
as code owners
This PR now enables support for those blocks, plus the Column block, and except the group block, which is in progress. We can use this WordPress Playground link to the Gutenberg PR previewer in order to play around with the changes introduced here.
Noted, and added! |
vcanales
added
[Type] Feature
madhusudhand
force-pushed
the
add-shadow-supports
branch
from
628fa23 to
6c802e5
Compare
|
It works well in testing except when they are in side a group block. Scenario 1: 
Scenario 2: 
Scenario 3: 
I expected it to work as scenario 1 (shadow getting trimmed) for both group blocks (as they contain single image). Note: This happens only in the editor. No issues in the frontend. |
vcanales
force-pushed
the
add-shadow-supports
branch
from
67704f9 to
01af895
Compare
|
Flaky tests detected in 10e89bf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7782529319
|
Investigated further on this. This is happening because of next group (when it has background), shadow goes under the next block and not visible because of the background. This is a theme specific issue and can be ignored. |
madhusudhand
force-pushed
the
add-shadow-supports
branch
from
01af895 to
52156bd
Compare
vcanales
force-pushed
the
add-shadow-supports
branch
from
52156bd to
028ee37
Compare
madhusudhand
force-pushed
the
add-shadow-supports
branch
from
028ee37 to
c0560de
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @bgardner. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
madhusudhand
force-pushed
the
add-shadow-supports
branch
from
c0560de to
e333d9f
Compare
madhusudhand
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
I went ahead to revert some of the additional changes of column and column blocks because the serialization change #58306 is now merged.
Also, removing group and cover block related changes as more testing is required.
LGTM for column, columns and image blocks.
madhusudhand
changed the title
vcanales
force-pushed
the
add-shadow-supports
branch
2 times, most recently
from
2ce0b4f to
4cfa087
Compare
9 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #57654
This PR adds box shadow support to the following blocks:
Cover— Requires additional work.Group- Requires additional testingIssue: #57103