Outline editable blocks when in a pattern that has locked children #57991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use :has() to outline editable blocks that are within a pattern that has locked children but are themselves not locked. For example a pattern that has multiple paragraphs, not in a container, and some of those paragraphs allows an override.
noisysocks
added
[Type] Bug
|
Size Change: +72 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks for the quick follow-up @noisysocks! This is working nicely for me now with a pattern where the partially synced block is at the root level of the pattern:
Everything is still testing well when editing a page in the site editor and a content locked pattern in the post editor 👍
I know previously the :has() pseudo-class had been avoided in GB due to delayed FF support. It looks like support appears to be pretty good now and :has() is already in use in a couple of other places (e.g. here). Since this isn't critical CSS (i.e.nothing would break if these rules don't work in older versions of Firefox), the inclusion here seems safe to me.
LGTM! ✨
|
Yeah I feel comfortable using this throughout Gutenberg now that Firefox has added support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #57901.
Use
:has()to outline editable blocks that are within a pattern that has locked children but are themselves not locked. For example a pattern that has multiple paragraphs, not in a container, and some of those paragraphs allows an override.Why?
Fixes the edge-case noticed by @andrewserong in #57901 (comment).
Testing Instructions
See #57901.