Allow selecting the template when editing a post #57992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
|
Pressing ⏸️ on this until @SaxonF demos it to his team next week. |
|
Size Change: +209 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 11ae7b4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7579640869
|
|
We're going to hold off on this part of #55025 for the moment. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follows #57901. Implements the rest of Part 1 of #55025.
Why?
See #55025.
How?
This is an alternative approach to #57786. Basically I am faking the entire block selection process and implementing my own
BlockToolbar. I think it's a winning approach, but will require some effort to get the details (Top toolbar, keyboard interaction, accessibility) right which I have not yet put in 🚧Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Kapture.2024-01-19.at.15.48.46.mp4