Support removing an attribute for Pattern Overrides #57993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Feature] Synced Patterns
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/pattern.php ❔ lib/experimental/block-bindings/block-bindings.php ❔ lib/experimental/block-bindings/class-wp-block-bindings.php ❔ lib/experimental/block-bindings/sources/pattern.php ❔ lib/experimental/block-bindings/sources/post-meta.php ❔ lib/experimental/blocks.php |
|
Size Change: +80 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 61a6dd4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7580217076
|
|
We'll revisit this in another format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #53705. An alternative to #57947.
This changes the overrides serialized data into a tuple with the following signature:
This also opens up the possibility of having an
insertpatch that we can use for adding inner blocks.Why?
As opposed to #57947. This change is based on the assumption that sometimes some attributes have different meanings between having
NULLas the value and not existing at all.However, I don't find any existing use case for such an assumption. So, we might not need this after all.
How?
Serialize the overrides data into a patch similar to the JSON patch schema
Testing Instructions
Follow the instructions in #53705 (comment) to create a pattern with overrides.
Screenshots or screencast
TBD