Updated/fixed contrast checker to respect recent changes on Notice component #5800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notices component changed and now instead of receiving a content prop renders the children. Contrast checker is now updated to take into account this recent change of the notices component. The test cases of ContrastChecker did not fail because they tested that the notices are shown when needed using the notice component, but did not test if the notices component, in fact, rendered the message. The use of shallow was changed to mount in the tests, as I think mount in this case, gives a bigger assurance that messages are in fact rendered. It may create false fails, e.g: class changes in notices. But when doing this changes we should probably test ContrastChecker so this fails just increase the probability of the manual inspection happening so they are good in my option.
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
changed the title
jorgefilipecosta
changed the title
jorgefilipecosta
changed the title
aduth
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notices component changed and now instead of receiving a content prop renders the children. Contrast checker is now updated to take into account this recent change of the notices component.
The test cases of ContrastChecker did not fail because they tested that the notices are shown when needed using the notice component, but did not test if the notices component, in fact, rendered the message. The use of shallow was changed to mount in the tests, as I think mount in this case, gives a bigger assurance that messages are in fact rendered. It may create false fails, e.g: class changes in notices. But when doing this changes we should probably test ContrastChecker so this fails just increase the probability of the manual inspection happening so they are good in my option.
How Has This Been Tested?
Go to paragraph and/or button block, set the same color for background and test. Verify contrast checker messages are shown correctly.