Stabilize the pattern overrides block context

[talldan]

What?

This PR stabilizes the pattern overrides block context, and partially removes the pattern overrides experiment.

Four core blocks are currently supported for pattern overrides, and the code in lib/block-supports/pattern.php previously added a way for those blocks to useContext when the pattern experiment was active. In this PR I'm instead adding the useContext declarations directly to the block.json files.

Why?

This should help with:

• Backports to core - the code in the pattern.php file no longer needs to be backported, the blocks wil be automatically updated in core along with package updates.
• Removing the pattern overrides experiment flag - the flag will be removed as part of shipping the feature in WordPress 6.5. The feature can also be released in Gutenberg 17.6, though this will require also removing the block binding experiment.

Testing Instructions

• Test patterns with the 'Pattern overrides' experiment turned off
• Test patterns with the 'Pattern overrides' experiment turned on (see instructions here)

Both should work the same as in trunk.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/load.php

[github-actions]

Flaky tests detected in c8ca2e9.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7622686822
📝 Reported issues:

• [Flaky Test] the event listener is removed when the element is removed #57983 in /test/e2e/specs/interactivity/directive-on-document.spec.ts

[kevin940726]

Tested well and code looks good! 👍

[kevin940726]

Should we add the overrides attribute in block.json or should we do in #58105?

[talldan]

Oh yeah, I did make that change but reverted it accidentally, I'll bring it back again.

[talldan]

Changed in c8ca2e9

[getdave]

@talldan I saw you noted that patterns.php has been removed. So we're good on this PR in terms of backports for 6.5?

[talldan]

Yep, I think we managed to move all the logic into block code, apart from the registration using the block binding API, but there's the block bindings backport PR that handles that.

[getdave]

✅ I updated the PHP Sync Tracking Issue for WP 6.5 to note this PR does not require a backport for WP 6.5.