Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Backport updates from Core #58107

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Jan 23, 2024

Updates from WordPress/wordpress-develop from 54a09a7 to 7a71339

The PHP files in the compatability layer are merged and maintained in the Core repo and all changes or updates need to happen first in Core and then be brought over to Gutenberg as built files.

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/html-api/class-gutenberg-html-processor-6-5.php
❔ lib/compat/wordpress-6.5/html-api/class-gutenberg-html-tag-processor-6-5.php

Copy link

github-actions bot commented Jan 23, 2024

Flaky tests detected in 577d4e9.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7690811472
📝 Reported issues:

@dmsnell dmsnell force-pushed the html-api/backport-scan-all-tokens branch 4 times, most recently from 66f67f6 to 577d4e9 Compare January 29, 2024 03:32
@dmsnell dmsnell marked this pull request as ready for review January 29, 2024 05:34
@dmsnell dmsnell force-pushed the html-api/backport-scan-all-tokens branch from 577d4e9 to 2766c09 Compare February 6, 2024 20:48
Copy link

github-actions bot commented Feb 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell, gziolo.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dmsnell <dmsnell@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dmsnell dmsnell force-pushed the html-api/backport-scan-all-tokens branch from 2766c09 to bbf3b58 Compare February 6, 2024 21:22
@dmsnell dmsnell added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup labels Feb 6, 2024
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you 😀

@dmsnell dmsnell force-pushed the html-api/backport-scan-all-tokens branch from bbf3b58 to 6811b66 Compare February 6, 2024 21:28
@dmsnell
Copy link
Member Author

dmsnell commented Feb 6, 2024

I trust you 😀

bold move 😉

thankfully these are only backports, so they represented reviewed, accepted, and merged code. thank you @gziolo

@dmsnell dmsnell force-pushed the html-api/backport-scan-all-tokens branch 2 times, most recently from 45d3e55 to 1b3533b Compare February 6, 2024 21:42
Updates from WordPress/wordpress-develop:
 - From: WordPress/wordpress-develop@54a09a7
 - To: WordPress/wordpress-develop@7a71339

 - Coding style changes.

 - WordPress/wordpress-develop#5762
   Adds support for the "any other tag" sections in the HTML Processor.

 - WordPress/wordpress-develop#5539
   Adds support for list elements in the HTML Processor.

 - WordPress/wordpress-develop#5897
   Adds support for HR elements in the HTML Processor.

 - WordPress/wordpress-develop#5895
   Adds support for the AREA, BR, EMBED, KEYGEN, and WBR elements
   in the HTML Processor.

 - WordPress/wordpress-develop#5903
   Adds support for the PRE and LISTING elements in the HTML Processor.

 - WordPress/wordpress-develop#5913
   Updates "all other tags" support in HTML Processor and updates list
   of void elements.

 - WordPress/wordpress-develop#5906
   Adds support for the PARAM, SOURCE, and TRACK elements in the HTML Processor.

 - WordPress/wordpress-develop#5907
   Adds support for the INPUT element in the HTML Processor

 - WordPress/wordpress-develop#5683
   Provides mechanism to scan all tokens in an HTML document in the Tag Processor.

 - WordPress/wordpress-develop#5976
   Avoids splitting text nodes on "<" character.

 - WordPress/wordpress-develop#5992
   Only recognize true CDATA-lookalike nodes.

 - WordPress/wordpress-develop#5975
   Prevent void tag nesting when calling `next_token()`

 - WordPress/wordpress-develop#6021
   Reset parser state after seeking.

 - https://core.trac.wordpress.org/changeset/57528
   Fix typo in setting token flag.

 - WordPress/wordpress-develop#6041
   Ensure consecutive text is all joined into one text node.

The PHP files in the compatability layer are merged and maintained in
the Core repo and all changes or updates need to happen first in Core
and then be brought over to Gutenberg as built files.

Co-authored-by: sergeybiryukov <sergeybiryukov@git.wordpress.org>
Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: dmsnell <dmsnell@git.wordpress.org>
@dmsnell dmsnell force-pushed the html-api/backport-scan-all-tokens branch from 1b3533b to 8995b66 Compare February 6, 2024 21:43
@dmsnell dmsnell merged commit 8995b66 into trunk Feb 6, 2024
56 checks passed
@dmsnell dmsnell deleted the html-api/backport-scan-all-tokens branch February 6, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants