Patterns: Add lock icon when user doesn't have permission to edit a pattern #58157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
Size Change: +199 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
49 tasks
|
Not sure we should use the lock icon here as we (over)use this icon to indicate block locking elsewhere throughout the editor. Usually when a user doesn't have permission to perform an action we simply don't show that action. For example most of the post sidebar is empty when logged in as an author. With that convention in mind, here I'd expect that Edit original should simply not appear. Is that the current behaviour? Is it causing confusion among users? If so, then I'd suggest a more suitable alternative that doesn't use the lock icon is to grey out Edit original and show the You do not have permission copy when hovering on the button. |
|
Ok, let's just wait and see if there is any negative feedback about this change to the synced pattern before we sorry about this. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a lock icon in the toolbar if a user does not have permission to edit the current synced pattern
Why?
When the experiment that includes #57036 is made public users that do not have edit permission for a synced pattern will not be able to edit the content of the pattern at all, so it would be good to give some indication that this is intentional.
How?
Adds a lock icon to the toolbar with tooltip if the synced pattern has no overrides set and the user is not the owner or an admin.
Testing Instructions
Edit originalbuttonauthoruser and insert the pattern and make sure you see a lock icon in the tool bar and the pattern is not editableEdit originalpatternScreenshots or screencast
Author user and pattern they don't own:
Author user and pattern they created: