DataViews Fix: Preview not displayed in Templates table layout #58254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Regression
|
Thanks for the PR! I have an alternative in place for some days with a different approach. My thinking was, if we cannot avoid |
|
Size Change: +6 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
@ntsekouras Thank you for letting me know about that PR! Indeed, I think the approach explored in #58062 makes more sense, so I'm happy to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a regression in #57804
What?
This PR fixes an issue where the preview is not displayed when the Template's data view is a table layout.
Before
After
Why?
In #57804,
display:flexwas applied to elements with the.dataviews-view-table__cell-content-wrapperclass.The child of this element is the element with the
page-templates-preview-fieldclass, but because it is a flexbox child, if it contains no content and does not have an explicit width, the width will always be zero.As a result, I found that the
BlockPreviewcomponent failed to obtain the width using theuseResizeObserver()hook, and the preview was not rendered.gutenberg/packages/block-editor/src/components/block-preview/auto.js
Lines 130 to 135 in 61f7d05
How?
I applied 100% width to an element with
page-templates-preview-fieldclass. We can also solve this by applyingflex:1instead, but I thinkwidthis more intuitive.Testing Instructions