-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Change text on pattern reset button #58286
Conversation
@SaxonF another suggestion was to move this to the overflow menu, what do you think about this? |
Size Change: -4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -408,7 +408,7 @@ export default function ReusableBlockEdit( { | |||
disabled={ ! overrides } | |||
__experimentalIsFocusable | |||
> | |||
{ __( 'Reset to original' ) } | |||
{ __( 'Reset' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need additional context for translators? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of existing uses of Reset
with no translator context, and this use does not seem be different to the existing ones, ie. they all relate to buttons or menu options that are resetting block content, etc. What context are you thinking might be needed in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just being too cautious for some languages that might need additional context but I can't think of any off the top of my head 😅. Let's keep it this way until we need it 😄.
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 13ef08d |
What?
Changes the text of the
Reset to original
button to justReset
Why?
Feedback suggested this was better.
How?
Updated the button text.
Testing Instructions
Reset
and works as expected.Screenshots or screencast
Before:
After: