useSettings: extract selector #58354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Jan 27, 2024
| ...paths | ||
| ), | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [ clientId, ...paths ] |
There was a problem hiding this comment.
Whether we spread the dependencies here or in useMemo, it should be the same.
ellatrix
commented
Jan 27, 2024
| @@ -26,7 +26,7 @@ import { shadow as shadowIcon, Icon, check } from '@wordpress/icons'; | |||
| /** | |||
| * Internal dependencies | |||
| */ | |||
| import { mergeOrigins } from '../use-settings'; | |||
| import { mergeOrigins } from '../../store/private-selectors/get-inherited-settings'; | |||
There was a problem hiding this comment.
Maybe this should be moved to a utils file, but I left it for now, there's only two uses.
|
Size Change: +108 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
ellatrix
force-pushed
the
try/get-inherited-settings
branch
from
0232d06
to
0ae33ce
Compare
ellatrix
force-pushed
the
try/get-inherited-settings
branch
from
356ad35
to
34c2821
Compare
jsnajdr
approved these changes
Jan 29, 2024
| ); | ||
| } | ||
|
|
||
| export function getInheritedSettings( state, clientId, ...paths ) { |
There was a problem hiding this comment.
I don't like the name very much, getBlockSettings is probably better. But it doesn't matter that much for a private API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR splits out the selector from
useSettings, so it can be combined with otheruseSelectselectors in a single subscription.Why?
There's a use case for inner blocks, reducing the blockEditor store subscriptions from 2 to 1, but there's also used cases in some blocks.
First run -10% type.
ALSO, the useSettings hook cannot be called conditionally, but the selector can. So you can do:
I've seen a few places where that could be useful to avoid even more subscriptions.
How?
I created a new
getBlockSettingsprivate selector. Not sure if the naming is correct.Testing Instructions
E2e tests should pass.
Testing Instructions for Keyboard
Screenshots or screencast