-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Hooks API: Update Navigation block feature gate #58388
Block Hooks API: Update Navigation block feature gate #58388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@c4rl0sbr4v0 We'd like to include this in GB 17.6. Should we cherry-pick to the (Edit: No need for a separate RC, IMO.) |
Flaky tests detected in d62993a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7698726773
|
Hi @ockham With the label is enough, I will do a RC3 tomorrow (for other PRs 😅 ), not this one. |
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 8a7d26b |
What?
Updates the feature gate for usage of the Block Hooks API to insert inner blocks into the core Navigation block.
Why?
We were previously checking for
get_hooked_blocks
to gate this feature against WordPress 6.3 and below, however this feature also depends upon the metadataignoredHookedBlocks
functionality to work correctly which isn't present within WordPress 6.4, resulting in a bug surfacing itself.How?
I've updated the feature gate to check for the function responsible for the
ignoredHookedBlocks
logic that we need, which prevents this running on WP 6.4 until compat code is ported over.Testing Instructions
On WP 6.4
On WP 6.5 Beta