getBlockSettings: avoid memoized selector with clientId #58405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fe53ba2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7701608481
|
jsnajdr
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Looks good. There are many other places where getBlockParents could be similarly replaced to avoid the memoized version.
Many of these selectors also look like good places to use generators and iterators. We could have a function:
function* listBlockParents( state, clientId ) {
for ( let clientId = ... ) { yield clientId; };
}and then use it like
const getBlockParents = () => [ ...listBlockParents() ];or
for ( const id of listBlockParents() )and with stage 3 iterator helpers we could even have
listBlockParents().every( ... );I'm wondering how that would perform. There are places where we are constructing large arrays and stacks, like flattenedBlocks in updateBlockTreeForBlocks, and they could be streamlined using iterators.
| if ( hasBlockSupport( name, '__experimentalSettings', false ) ) { | ||
| candidates.push( id ); | ||
| } | ||
| } while ( ( id = state.blocks.parents.get( id ) ) ); |
There was a problem hiding this comment.
Could it be a for loop?
for ( let id = clientId; id; id = state.blocks.parent.get( id ) ) {}That eliminates also the if ( clientId ) condition.
There was a problem hiding this comment.
It could be I guess 🤔 Personally I don't find standard for loops very readable, I tend to avoid them
|
Let's wait with merging this for a few commits to see result of #58355 |
|
@jsnajdr Yes that would be nice, that way you avoid looping over the same array multiple times if you need to filter it afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Calling getBlockParent( clientId ) causes a cache lookup which may be large for a large number of blocks. We don't need a stable reference in getBlockSettings so it should be faster to directly get the parents.
Why?
We use
getBlockSettingswithin the inner blocks hook, and note that every list AND list item (even without nested lists) will run this hook, as well as galleries, quotes etc.First run site editor load -3.2%, next runs seems to be around 1%...
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast