Script loader 6.4 compat: check for init hook completion

[ramonjd]

What, why, how?

Core checks that the init hook is complete before trying to use the global $wp_locale value in wp_default_packages_inline_scripts, which is where the date settings are set for inline JS.

This change backports that from Core.

Note

No Core backport required as the changes from #53931 were ported over in WordPress/wordpress-develop#5101

Testing Instructions

Test steps in #53931 should work as expected.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.4/script-loader.php

[andrewserong]

Thanks for fixing this up @ramonjd!

This looks like a good way to do it to me, as it follows how it's guarded in core 👍

✅ Confirmed that wp.date.getSettings() works as before in the site editor, returning translated settings
✅ Double-checked that $wp_locale in core is set to an instance of WP_Locale, which sets public properties with empty arrays, so if $wp_locale is set, then we don't need to check if the properties are arrays before accessing them
✅ Double-checked that the locale is instantiated set before init here: https://github.com/WordPress/wordpress-develop/blob/a61525049f574a826cf20a8b1b624e1b42970b10/src/wp-settings.php#L613

LGTM! ✨

[ramonjd]

Appreciate the lightning fast review @andrewserong 🙇🏻