Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Address Android E2E tests failure by setting fixed versions of Appium drivers #58408

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 29, 2024

Related PRs:

What?

Set fixed versions of Appium drivers to address failures in Android E2E tests encountered after merging #58274.

Why?

Fixes and re-enables Android E2E tests.

How?

Appium drivers are cached using the checksum of the package-lock.json file (reference). This implies that when this file is modified, the Appium drivers are installed. However, we are installing the most recent version which might be incompatible with the current Appium version as it can be read in the Appium CLI documentation of update command:

[...] By default, Appium will not automatically update any extension that has a revision in its major version, so as to prevent unintended breaking changes.

The usage of different versions can be seen in the CI jobs of release PRs:

For this reason, we are setting a fixed version for Appium drivers to address potential issues when running E2E tests.

Additionally, this PR reverts #58376 to re-enable Android E2E tests.

Testing Instructions

  • Observe that React Native E2E Tests (Android) CI job succeeds.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

@fluiddot fluiddot added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jan 29, 2024
@fluiddot fluiddot marked this pull request as ready for review January 30, 2024 08:33
Comment on lines +8 to +9
UI_AUTOMATOR_2_VERSION="2.32.3"
XCUITEST_VERSION="5.7.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions are the ones I had locally installed. So far, they haven't produced incompatibilities. In the future, we might consider updating them if necessary.

Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work! I've confirmed it uninstalls other versions correctly (if they exist) and installs the expected ones.

@fluiddot fluiddot merged commit 8345d2b into trunk Jan 30, 2024
61 checks passed
@fluiddot fluiddot deleted the rnmobile/fix/android-e2e-tests-appium-drivers branch January 30, 2024 10:58
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants