Data views: Update 'Rows per page' view option label to account for Grid layout #58457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: -1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I prefer to use "Items per page" for all layouts. It feels versatile and matches any layout. In the core dashboard, everything is unified with "Number of items per page" (even the user list!)
|
|
Flaky tests detected in 5c1b760. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7730042624
|
|
I think the question of what words to use is also related to #58482, which aims to improve the messages when there are no results. |
|
Items per page seems good to follow 👍 👍 |
|
Thanks both. I updated to remove the logic and use 'Items per page' regardless of layout: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When the grid layout is selected the 'Rows per page' view option now reads 'Entries per page'.
Why?
In the context of grid layout 'Rows per page' is ambiguous. Does it refer to the individual items or the number of rows in the grid?
Testing Instructions
I'd appreciate input from @WordPress/gutenberg-design on the terminology. Possible alternatives to 'entries':
Worth noting that all of these options could effectively account for any layout meaning we could potentially remove the conditional logic and simplify things a bit. I suppose that's a question of consistency versus specificity.