Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block editor: Image link update active status when lightbox is enabled #58490

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Block editor: Image link update active status when lightbox is enabled #58490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6174d31
Update label; update active status when lightbox is enabled
artemiomorales Jan 30, 2024
f861057
Update e2e with label change
cbravobernal Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-editor/src/components/url-popover/image-url-input-ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,11 @@ const ImageURLInputUI = ( {
<ToolbarButton
icon={ linkIcon }
className="components-toolbar__control"
label={ url ? __( 'Edit link' ) : __( 'Add link' ) }
label={ __( 'Link' ) }
aria-expanded={ isOpen }
onClick={ openLinkUI }
ref={ setPopoverAnchor }
isActive={ !! url }
isActive={ !! url || lightboxEnabled }
/>
{ isOpen && (
<URLPopover
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/blocks/image.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ test.describe( 'Image', () => {
imageBlock.locator( 'data-testid=form-file-upload-input' )
);

await page.getByLabel( 'Block tools' ).getByLabel( 'Add link' ).click();
await page.getByLabel( 'Block tools' ).getByLabel( 'Link' ).click();

// This form lacks distinguishing qualities other than the
// class name, so we use page.locator() instead of page.getByRole()
Expand Down
Loading