Block editor: reduce appender sync! subscriptions #58556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
changed the title
|
Size Change: -13 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Feb 1, 2024
| // Avoid passing CustomAppender to useSelect because it could be a new | ||
| // function on every render. | ||
| const hasAppender = CustomAppender !== false; | ||
| const hasCustomAppender = !! CustomAppender; |
There was a problem hiding this comment.
What's the difference between these two flags?
There was a problem hiding this comment.
I hoped the const name was descriptive 😄
One is to check if there's an appender in general: either CustomAppender === undefined or a component
The other is to check if there's a custom appender defined: CustomAppender must be a function (truthy)
There was a problem hiding this comment.
I guess the "undefined" is what tricked me
There was a problem hiding this comment.
I guess we should set a default to true
There was a problem hiding this comment.
Actually that won't work because we have another check CustomAppender ? ...
There was a problem hiding this comment.
I guess we could check boolean there, anyway I left it as is for now.
youknowriad
approved these changes
Feb 1, 2024
ellatrix
force-pushed
the
optimise/appender
branch
from
d7092ea to
4744c99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes 2 block editor store subscriptions for almost each inner block list.
Both of these subscriptions were sync subscriptions.
Why?
First run type -12.5%, second run -5.2%
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast