RichTextData: use a private property #58557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
jsnajdr
commented
Feb 1, 2024
| this.originalHTML || | ||
| toHTMLString( { value: this[ RichTextInternalData ] } ) | ||
| ); | ||
| return this.originalHTML || toHTMLString( { value: this.#value } ); |
There was a problem hiding this comment.
The way how originalHTML is defined in fromHTMLElement is not entirely correct. It effectively creates a live binding between the htmlElement and the RichTextData value. If the element's contents change, then toHTMLString() will read the latest .innerHTML value in the getter.
Other parts of the RichTextData value are however not live: the toPlainText method, the .text getter, etc. The object's content can be inconsistent and out of sync.
There was a problem hiding this comment.
RichTextData should not be mutable
There was a problem hiding this comment.
Then we need to read htmlElement.innerHTML only once in RichTextData constructor, not on every call of .toHTMLString.
There was a problem hiding this comment.
We do it only once in the static method? originalHTML is a value not a getter?
There was a problem hiding this comment.
Or do you mean toHTMLString()? We shouldn't calculate it in the constructor for performance, we sure we could cache it here for the next call
There was a problem hiding this comment.
(We only want to serialise when it's needed)
There was a problem hiding this comment.
originalHTMLis a value not a getter?
Oh, somehow I overlooked this 🙂 It's alright then.
|
I have tried this but it didn't work for me. Would be cool if it works :) |
|
Oh, TypeScript makes a complaint I don't understand: because we define |
|
Size Change: -19 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I fixed the TypeScript error. It was the Maybe @noahtallen or @sirreal know a way how to make |
|
The goal is to run |
Yes, the goal is to typecheck one specific file with a config for a particular project. |
|
Hello, I am getting "SyntaxError: Invalid character: '#'" on Safari IOS 14.3 and I have narrowed it down to this MR. It seems to work correctly on any other browser I have tested (Windows and Android). I am not sure if I should create a new Issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
RichTextData, use a private class instance property for the private data, instead of a symbol-indexed public property. Private properties are now standard, they should work.