Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Change referenced tab name on Google Fonts confirmation dialog #58584

Merged

Conversation

ironprogrammer
Copy link
Contributor

Fixes the tab referenced for manual uploads to "Upload" in the Google Fonts dialog.

What?

I changes the tab name from "Library" to "Upload".

Why?

Users cannot upload via the referenced Library tab, but must use the Upload tab.

How?

A string change.

Testing Instructions

  1. If you have previously granted permission for the Font Library to access Google Fonts, in your browser, delete the local storage key for wp-font-library-google-fonts-permission to re-enable the dialog.
  2. Open the Styles panel in the site editor.
  3. Open Typography and then the "Manage fonts" icon (the stylized "Aa" glyph above the fonts list), and click the "Install Fonts" tab.
  4. The text in the second paragraph of the dialog should read: "You can alternatively upload files directly on the Upload tab."

Testing Instructions for Keyboard

n/a

Screenshots or screencast

SCR-20240201-orsw

Library tab does not support uploads.
@ironprogrammer ironprogrammer added the [Feature] Typography Font and typography-related issues and PRs label Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: ironprogrammer.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ironprogrammer ironprogrammer changed the title Change referenced tab name on Google Fonts confirmation dialog Font Library: Change referenced tab name on Google Fonts confirmation dialog Feb 2, 2024
@t-hamano t-hamano self-requested a review February 5, 2024 10:18
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@t-hamano t-hamano added the [Type] Bug An existing feature does not function as intended label Feb 5, 2024
@t-hamano t-hamano merged commit da8d9e9 into WordPress:trunk Feb 5, 2024
60 of 63 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants