Show borders for disabled secondary buttons. #58606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Thanks for the green check! I'll leave this up for the weekend to see if others chime in with any observations. Mainly I want to just move slightly carefully with this one, since the Button component is so broadly used. |
mirka
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Looks good!
Not sure if we shared this with you but FYI, we have a matrix of Button variants in a non-public Storybook that may be useful when testing changes like this.
Run npm run storybook:e2e:dev and see the Button ▸ Variant States story.
|
That is useful indeed. Thank you! Then I'll land this, it looks right, and I'll always be happy to follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Secondary buttons have outlines. But not when disabled. This is causing the component to be less reliable in such sitautions, as evident by it floating a bit for the "Switch to draft" button:
This PR changes the CSS so that the secondary button always has a border, even when disabled:
Testing Instructions