Fix font library unit tests nit-picks [round 2]

[anton-vlasenko]

What?

Updates the Font Library's PHPUnit tests to comply with the WordPress Core Test coding standards and practices.

Follow-up from #58502.

WP_Test_REST_TestCase::assertErrorResponse() doesn't adhere to the coding standards, so I've created a Trac ticket to address that as well: https://core.trac.wordpress.org/ticket/60426.

Why?

To prepare the test suite for Core sync / merge, as these changes will get flagged in review. By fixing them now, it can help to reduce the review time and change requests at Core merge time.

How?

• Removed the assignment of an empty array to $post_ids_to_delete in the Tests_Font_Family_Backwards_Compatibility class, as it's unnecessary.
• Replaced json_encode with wp_json_encode in the mock_request method within the wpFontCollection/loadFromJson.php file to ensure consistent JSON encoding.
• Replaced json_encode with wp_json_encode in the mock_request_missing_slug method within the wpFontCollection/loadFromJson.php file to ensure consistent JSON encoding.
• Updated the assertion message in the test_should_get_mock_font_collection method in the wpFontLibrary/getFontCollections.php file to fix a typo in the word "Should."
• Updated a comment in the unregister_non_existing_collection method in the wpFontLibrary/unregisterFontCollection.php file to fix a typo by changing "non existing" to "non-existing."
• Corrected assertion message in the test_register_routes method in the wpRestFontCollectionsController.php file by adding a missing "initialized" to "intialized."
• Corrected assertion message in the test_register_routes method in the wpRestFontCollectionsController.php file by adding a missing "initialized" to "intialized."
• Corrected assertion message in the test_register_routes method in the wpRestFontCollectionsController.php file by adding a missing "initialized" to "intialized."
• Updated the method name from test_create_item_santize_font_family to test_create_item_sanitize_font_family in the wpRestFontFacesController.php file to fix a typo.
• Updated the method name from data_create_item_santize_font_family to data_create_item_sanitize_font_family in the wpRestFontFacesController.php file to fix a typo.
• Updated the method name from test_create_item_santize_font_family to test_create_item_sanitize_font_family in the wpRestFontFacesController.php file to fix a typo.
• Updated the method name from data_create_item_santize_font_family to data_create_item_sanitize_font_family in the wpRestFontFacesController.php file to fix a typo.
• Updated variable names in the check_file_meta method in the wpRestFontFacesController.php file to more accurately reflect their purpose by changing $srcs to $src_attributes.
• Updated variable names in the check_file_meta method in the wpRestFontFacesController.php file to more accurately reflect their purpose by changing $srcs to $src_attributes.

Testing Instructions

All PHPUnit tests and test code linting checks should still pass.

Testing Instructions for Keyboard

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: antonvlasenko, get_dave.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ phpunit/tests/fonts/font-library/fontFamilyBackwardsCompatibility.php
❔ phpunit/tests/fonts/font-library/wpFontCollection/loadFromJson.php
❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollections.php
❔ phpunit/tests/fonts/font-library/wpFontLibrary/unregisterFontCollection.php
❔ phpunit/tests/fonts/font-library/wpRestFontCollectionsController.php
❔ phpunit/tests/fonts/font-library/wpRestFontFacesController.php

[getdave]

These fixes look good to me. Thank you.