Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Minor copy edits for the Block Development Environment page #58614

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Feb 2, 2024

This PR makes some minor copy changes to Block Development Environment page to improve readability. One line is also turned into a callout.

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Feb 2, 2024
@ndiego ndiego self-assigned this Feb 2, 2024
@WordPress WordPress deleted a comment from github-actions bot Feb 2, 2024
@desrosj
Copy link
Contributor

desrosj commented Feb 2, 2024

👋 Sorry for any noise. I'm using this draft PR as a way to test a few changes to Props Bot.

Copy link

github-actions bot commented Feb 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: ndiego, desrosj, fabiankaegy.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ndiego <ndiego@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 2, 2024

Flaky tests detected in dcdd145.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7757124099
📝 Reported issues:

@ndiego ndiego marked this pull request as ready for review February 2, 2024 14:35
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ndiego
Copy link
Member Author

ndiego commented Feb 2, 2024

@desrosj should I wait to merge this (once approved) until you are done testing? If so, just ping me when the coast is clear.

@ndiego ndiego merged commit 04bb9e8 into trunk Feb 2, 2024
63 checks passed
@ndiego ndiego deleted the docs/copy-edits-for-deveenv-readme branch February 2, 2024 16:24
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 2, 2024
@desrosj
Copy link
Contributor

desrosj commented Feb 2, 2024

Just seeing this, but merging was totally fine! I was able to get everything sorted out (see #58617).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants