-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: innerBlocks schema description in block.json #58649
fix: innerBlocks schema description in block.json #58649
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @shreyash3087, @MHRSRoni. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core SVNIf you're a Core Committer, use this list when committing to
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @shreyash3087! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I think this approach makes sense, but I'll leave a comment with the code example.
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
@t-hamano Thanks for taking the time to review my pull request and providing your valuable feedback,i updated the code accordingly as per your suggestion.This was my first contribution to open source, so i truly appreciate your guidance. |
@t-hamano Thank you for the correction! I have updated the description in the block.json file. Sorry for the inconvenience here,but i don't know why the 'End-to-End Tests / Puppeteer (pull_request)' is now failing after 9m,i looked into the details its a TimeoutError. But i couldnt find the reason behind that. Please review the changes and the error at your convenience. Your guidance is greatly appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your first merged pull request, @shreyash3087! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
What?
This PR corrects the schema description for example.innerBlocks in the block schema to accurately reflect the expected format.
Fixes #58381
Why?
The incorrect description was causing confusion for users and potentially leading to incorrect usage of the
innerBlocks
property. This PR is necessary to provide clear and accurate instructions for defining inner blocks within the block example.How?
This PR updates the description in the block schema file (
block.json
) to match the correct format for defining inner blocks. It removes syntax errors and provides clear instructions on how to use theinnerBlocks
property.Testing Instructions
Testing Instructions for Keyboard
1.Navigate to block.json using keyboard navigations.
2.Head down to around 700 lines and search for innerBlocks description.
Screenshots or screencast