Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Collections: standardizes docblock comments #58654

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

creativecoder
Copy link
Contributor

What?

Touches up the docblock comments related the font collections and font collection registration

Why?

To align with Core standards.

How?

  • Removes extra line in WP_Font_Collection property docblocks.
  • Puts canonical font collection param descriptions in wp_register_font_collection and adds references to that function in related functions/methods.
  • Fixes typo

Testing Instructions

n/a

Copy link

github-actions bot commented Feb 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: grantmkin, youknowriad.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 5, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-utils.php
❔ lib/compat/wordpress-6.5/fonts/fonts.php

@youknowriad
Copy link
Contributor

I've rebased this PR to resolve some minor conflicts, it should be ready to go now.

@youknowriad youknowriad enabled auto-merge (squash) February 5, 2024 08:45
Copy link

github-actions bot commented Feb 5, 2024

Flaky tests detected in 8581fbc.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7781757751
📝 Reported issues:

@youknowriad youknowriad merged commit 7a6f458 into trunk Feb 5, 2024
57 checks passed
@youknowriad youknowriad deleted the fix/font-library-docblocks branch February 5, 2024 09:15
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants